Closed kkebo closed 4 years ago
Merging #182 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 43 43
Lines 2332 2332
=======================================
Hits 1710 1710
Misses 622 622
Impacted Files | Coverage Δ | |
---|---|---|
Sources/XMLCoder/Decoder/XMLDecoder.swift | 76.29% <ø> (-0.35%) |
:arrow_down: |
Sources/XMLCoder/Encoder/XMLEncoder.swift | 85.61% <100.00%> (+0.21%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ac411bd...18282b5. Read the comment docs.
@MaxDesiatov It seems that danger-lint has failed in XMLDecoder
, but I didn't change XMLDecoder
at all. Do you have any ideas?
No worries, that seems like a SwiftLint bug 🙂
TopLevelEncoder
implementation was added by #175. However, its method cannot be overridden. If it can be, we can use custom root key, root attributes, or header even when we use Combine-style like this:So, I proposed the solution.