search

CoreOffice / XMLCoder

Easy XML parsing using Codable protocols in Swift
https://coreoffice.github.io/XMLCoder/
MIT License
795 stars 107 forks source link

Compile as dynamic library on Linux #200

Closed colemancda closed 3 years ago

colemancda commented 4 years ago

Build as .so instead of .a on Linux for use across different libraries and executables.

codecov[bot] commented 4 years ago

Codecov Report

Merging #200 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          43       43           
  Lines        2359     2359           
=======================================
  Hits         1739     1739           
  Misses        620      620

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 524de45...3b16403. Read the comment docs.

MaxDesiatov commented 4 years ago

Thanks for the PR. Could you clarify please how is this supposed to work if our Linux users want a static library? Last time I talked to SwiftPM folks, their opinion was that this should be controlled on library consumer side, not library vendor side, otherwise consumers lose all flexibility.

MaxDesiatov commented 3 years ago

With no updates from the OP I'm closing this as stale.