search

CoreOffice / XMLCoder

Easy XML parsing using Codable protocols in Swift
https://coreoffice.github.io/XMLCoder/
MIT License
795 stars 107 forks source link

Encode element with empty key, empty element, and attributes #223

Closed wooj2 closed 3 years ago

wooj2 commented 3 years ago

Original description is in this issue: https://github.com/MaxDesiatov/XMLCoder/issues/224

codecov[bot] commented 3 years ago

Codecov Report

Merging #223 (bc89de7) into main (487ece5) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   73.87%   73.94%   +0.06%     
==========================================
  Files          46       46              
  Lines        2431     2437       +6     
==========================================
+ Hits         1796     1802       +6     
  Misses        635      635
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.49% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 487ece5...bc89de7. Read the comment docs.

wooj2 commented 3 years ago

Seems legit, thanks

WOW you are toooo quick! haha.. I removed the ignore swift lint, and just reduced the name so that it is under 200 characters, thanks!