Closed MartinP7r closed 3 years ago
Merging #225 (c802db7) into main (887de88) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 73.94% 73.94%
=======================================
Files 46 46
Lines 2437 2437
=======================================
Hits 1802 1802
Misses 635 635
Impacted Files | Coverage Δ | |
---|---|---|
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift | 96.49% <100.00%> (ø) |
|
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift | 93.93% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 887de88...c802db7. Read the comment docs.
Thank you!
Any idea what the intention behind the parameter was in the first place?
Thanks for the contribution! I wouldn't remember at this point. It could've been introduced accidentally, or it could be something vestigial and lost its purpose after some refactoring. The main thing is that it's now cleaned up 🙂
The parameter was not used inside the method and only had one call-site
Please ignore if you are planning to use the parameter in some way.
All tests are passing