search

CoreOffice / XMLCoder

Easy XML parsing using Codable protocols in Swift
https://coreoffice.github.io/XMLCoder/
MIT License
793 stars 104 forks source link

Fix mixed CDATA usage #261

Closed johankool closed 1 year ago

johankool commented 1 year ago

Fixes #260

Joannis commented 1 year ago

Thanks for your contribution! I'll let the tests run, and run it through myself. But it looks good for sure.

johankool commented 1 year ago

Not sure what went wrong with the tests. Can they be re-run?

Joannis commented 1 year ago

Done

johankool commented 1 year ago

Not sure what to do about this. I don't have Xcode 13.1 on macOS 11.0 available to me, so can't easily reproduce. Not sure why anyone would still use that either.

Joannis commented 1 year ago

I agree with you @johankool , it's an old platform. And even the Xcode build is old for the specific platform. If you want, you can replace the target with a Ventura / Xcode 14 one to get the tests running. I'll make sure we'll also add Linux/5.7 and Linux/5.8 after that.

Joannis commented 1 year ago

Actually, the latest tests (Xcode 14, macOS 12) never ran to begin with. So I do think there's something at play.

Joannis commented 1 year ago

I feel like this is a github runner issue, so I've merged it.