CoreOffice / XMLCoder

Easy XML parsing using Codable protocols in Swift
https://coreoffice.github.io/XMLCoder/
MIT License
801 stars 112 forks source link

Empty codingkey encode decode output #267

Closed Alkenso closed 9 months ago

Alkenso commented 1 year ago
Alkenso commented 1 year ago

@Joannis , please review. Probably you'll find some additional cases that I could miss due to pretty complex conditions of decoding

Joannis commented 1 year ago

I need a bit more time for review, but could you document your intended behaviour here? That helps me review, and end users understand how encoding/decoding enum cases works.

Alkenso commented 1 year ago

Such functionality allows the ability to inline one of codable fields. It works exactly like already documented paragraph Coding key value intrinsic, but this implementation works for complex types, not only simple ones

Also I decided to simplify dealing with Choice containers. Added tests, update README.

Alkenso commented 1 year ago

@Joannis , update with additional fixes

Alkenso commented 1 year ago

@Joannis , ping

Joannis commented 1 year ago

Thanks for the ping! The PR was made at a very unfortunate time, so it got missed

Joannis commented 1 year ago

@Alkenso CI's failing on your changes: https://github.com/CoreOffice/XMLCoder/actions/runs/5207978882/jobs/9425283354?pr=267

Alkenso commented 1 year ago

@Joannis , I dont know how it is possible. Locally all builds fine. Please check on yours

Extension of protocol CodingKey adds method isInlined. Dont think it didnt work on Xcode 13...

Alkenso commented 1 year ago

@Joannis , please re-run CI. Maybe the CI issue could occur because I've made force-push of last commit instead making new one?

Joannis commented 1 year ago

I did re-run it a couple of times, but the CI keeps failing to spin up a worker. I don't know what is going on at Github..

Joannis commented 1 year ago

image

Alkenso commented 1 year ago

@Joannis , lets revive this PR. Probably we can move to Xcode 14-15 for builds

Joannis commented 1 year ago

@Alkenso Yeah, I think that's a good plan.