CoreSphere / ConsoleBundle

Commandline interface in browser for Symfony2
BSD 3-Clause "New" or "Revised" License
140 stars 54 forks source link

Catchable Fatal Error #53

Closed thomas-latterner closed 9 years ago

thomas-latterner commented 9 years ago

Hello,

Got an error message :

Catchable Fatal Error: Argument 3 passed to CoreSphere\ConsoleBundle\Controller\ConsoleController::__construct() must be an instance of Symfony\Bundle\FrameworkBundle\Console\Application, string given, called in [myPath]\app\cache\dev\appDevDebugProjectContainer.php on line 462 and defined" at [myPath]\vendor\coresphere\console-bundle\Controller\ConsoleController.php line 45

olix21 commented 9 years ago

Not the same, but close for me:

Catchable Fatal Error: Argument 3 passed to CoreSphere\ConsoleBundle\Controller\ConsoleController::__construct() must be an instance of Symfony\Bundle\FrameworkBundle\Console\Application, string given, called in [my_path]/app/cache/dev/appDevDebugProjectContainer.php on line 638 and defined

TomasVotruba commented 9 years ago

Could you find what string it is? Also, what version do you use?

thomas-latterner commented 9 years ago

The string is "dev" : protected function getCoresphereConsole_ControllerService() { return $this->services['coresphere_console.controller'] = new \CoreSphere\ConsoleBundle\Controller\ConsoleController($this->get('templating'), $this->get('coresphere_console.executer'), 'dev'); }

Version : "dev-master". Can't found the version number.

It's look like the third argument is missing : public function __construct( EngineInterface $templating, CommandExecuterInterface $commandExecuter, Application $application, $environment )

TomasVotruba commented 9 years ago

Thank you. I've prepared fixing PR.

Also I recommend you using stable version to prevent such issues. Any commit can break the master, so it's not very safe to use dev-master tag.

thomas-latterner commented 9 years ago

Thank you too. I take note about the dev-master tag.

TomasVotruba commented 9 years ago

@skududufru @olix21 It's merged, could you test composer update and confirm it's ok now?