Seems to be working. Although the current way the proxy test in client_test.go works is causing a goroutine leak that goleak detects. Two ways to fix that:
Properly close the socks5 server somehow.
Ignore the leak for the test. (which is less clean, but acceptable IMO, it's a self-contained test)
I haven't been able to ignore it even with goleak's method that I commented-out in warc_test.go. Although of course the 1st way would be the cleaner way to do that.
Seems to be working. Although the current way the proxy test in client_test.go works is causing a goroutine leak that goleak detects. Two ways to fix that:
I haven't been able to ignore it even with goleak's method that I commented-out in warc_test.go. Although of course the 1st way would be the cleaner way to do that.