CorentinTh / enclosed

Minimalistic web app designed for sending private and secure notes.
https://enclosed.cc
Apache License 2.0
683 stars 51 forks source link

fix(layout) Adjust new note button on mobile #182

Closed Zoobdude closed 1 month ago

Zoobdude commented 1 month ago

Currently on mobile devices the nav bar is pretty full: image

I was thinking how to make this slightly tidier, and tried hiding the text: image

@CorentinTh Any suggestions of a better way to do this or would you rather just keep it with the text?

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed-docs ✅ Ready (View Log) Visit Preview cb867c8f86e0386684801be506e686e99a12e4a2
enclosed ✅ Ready (View Log) Visit Preview cb867c8f86e0386684801be506e686e99a12e4a2
CorentinTh commented 1 month ago

Thanks for addressing this point! I was considering grouping all the icons (GitHub, i18n, etc.) inside the 3-dots dropdown menu when on small screen (perhaps we could replace it with a "hamburger" icon when they are grouped? I dunno)

But we can also replace the creation button with an icon

Zoobdude commented 1 month ago

Good idea! I'll work on this over the weekend.

Zoobdude commented 1 month ago

Not sure what SonarCloud is complaining about? Is this okay to ignore or shoud I use className instead?

CorentinTh commented 1 month ago

Yeah you may ignore the className stuff, it's an issue on sonarcloud side, it interprets the jsx as react and not solid, I'm marking them as false positive, I need to dig the config to exclude this rule

Zoobdude commented 1 month ago

Hope you're happy with the way I've implemented it, let me know if there's any revisions you would like me to make.

For the translations, should I leave them blank or use Google translate?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud