search

CorentinTh / it-tools

Collection of handy online tools for developers, with great UX.
https://it-tools.tech
GNU General Public License v3.0
23.1k stars 2.8k forks source link

fix(FavoriteButton) fix favorite button funtionality on tool page #1368

Closed gitmotion closed 3 weeks ago

gitmotion commented 3 weeks ago

@CorentinTh Bug Fix: https://github.com/CorentinTh/it-tools/issues/1365 before and after: beforeafterdemo

- previously was not passing the route path to the object when passing as tool: toollayoutonlypassesname frompageonlypassesname

- this also caused it to add nulls to the favoritesToolName in local storage: addsnull

- adding the path should prevent nulls from getting added now but also added if check before adding directly to the store: after change

vercel[bot] commented 3 weeks ago

@gitmotion is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Oct 25, 2024 4:27pm