search

CorentinTh / it-tools

Collection of handy online tools for developers, with great UX.
https://it-tools.tech
GNU General Public License v3.0
18.4k stars 2.21k forks source link

[FEAT] Suggest to use @qrcode-js/qrcode as qrcode generator #275

Open ruggi99 opened 1 year ago

ruggi99 commented 1 year ago

Hi, great project saw on noted.lol.

I'm the author of @qrcode-js/qrcode a library for Node and browser to generate qrcodes.

Maybe it's worth to try it and see if it's better than qrcode

CorentinTh commented 1 year ago

Hi @ruggi99 Thank you for the suggestion!

What would the benefits of using @qrcode-js/qrcode instead of qrcode ? Does it have more interesting features ?

TCB13 commented 1 year ago

I would rather see https://github.com/nuintun/qrcode because it also had the ability to decode QR codes and that would be a very nice feature!

ruggi99 commented 1 year ago

Hi @CorentinTh , sorry for being late and Happy Easter.

I think it has the same features like qrcode but you can personalize the output of the canvas like you want. You can style it like Telegram or Instagram via a property or you can style on your own via a function. For example: Do you want your dots being a triangle instead? Then write a function (in Javascript) that draws a triangle on the canvas.

Also my project is a monorepo that provides a core library and wrappers around it for NodeJs and browser. So if someone wants to use it only on browser than it would not have to download node-canvas (as a dependency) that it weights around 250 MB if I remember correctly (that was a problem I was facing in a old project and that's why I wrote the monorepo). Also my library should work with Vanilla JS and all framework out there, even Vue.js.

As pointed out my library does not decode qrcodes and I have no plan to support it because I strongly think that encoding and decoding qrcodes are separate functions that share almost no code between them.

I have a PR pending wrapping fastify and docker around the core library to create a server serving qrcodes.

sharevb commented 3 weeks ago

Hi @ruggi99, @TCB13 and @CorentinTh, implemented enhancements of qr code generator in https://github.com/CorentinTh/it-tools/pull/1104 and QR decoder in https://github.com/CorentinTh/it-tools/pull/914

TCB13 commented 2 weeks ago

Hi @ruggi99, @TCB13 and @CorentinTh, implemented enhancements of qr code generator in #1104 and QR decoder in #914

Thank you very much for providing this features :)