implem filters - Githubissues

lucas-amiaud commented 2 months ago

Dans cette PR :

Gestion des filtres à appliquer sur une liste chargée en mémoire
Gestion des filtres à appliquer sur une liste chargée en lazy avec un webservice
Affichage des filtres sur la barre latérale à coté d'une liste
Affichage d'une recherche textuelle au dessus des filtres

amanteaux commented 2 months ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 2 months ago

PR Reviewer Guide 🔍

(Review updated until commit https://github.com/Coreoz/create-plume-react-project/commit/1d61ae00ec70497d914fe94c81643163a41a865e)

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

Possible Bug
The `info` prop in the `Tooltip` component should be checked for null or undefined before rendering the `Tooltip` to avoid empty tooltips. Code Clarity
The `onValueClicked` and `onSingleValueClicked` functions are very similar and could be refactored into a single function with parameters to handle both cases, improving code reuse and readability. Redundant Code
The `onClear` function is redundantly checked before calling in the `IconButton`'s `onClick`. Since `onClear` is optional, it should be provided with a default no-operation function or handled differently to simplify the component's usage.

amanteaux commented 2 months ago

@vincentdbs et @Wail-LT Vous avez des remarques sur ça ? Vous pouvez regarder directement le fichier UsersList.tsx ou c'est utilisé, sinon c'est long.

CodiumAI-Agent commented 2 months ago

Persistent review updated to latest commit https://github.com/Coreoz/create-plume-react-project/commit/1d61ae00ec70497d914fe94c81643163a41a865e

Coreoz / create-plume-react-project

implem filters #42

PR Reviewer Guide 🔍

(Review updated until commit https://github.com/Coreoz/create-plume-react-project/commit/1d61ae00ec70497d914fe94c81643163a41a865e)