search

CoretechR / OMOTE

Open Source Remote Using ESP32 and LVGL
https://hackaday.io/project/191752
GNU General Public License v3.0
1.02k stars 114 forks source link

Fixes a wifi stability issue. #68

Closed mcurtiss1992 closed 3 months ago

mcurtiss1992 commented 3 months ago

WiFi library attempts to connect to a broken connection and fails until a sleep cycle is performed. This is solved by ending the current broken connection using WiFi.disconnect() before we attempt to start a new connection.

KlausMu commented 3 months ago

Thanks @mcurtiss1992 for your PR. I'm wondering which branch you used. Was it the main branch https://github.com/CoretechR/OMOTE/tree/main or the latest feature branch here https://github.com/KlausMu/OMOTE/tree/modular-approach

The main branch is known to have problems with WiFi because of memory issues. The feature branch has a significant change with regards of memory usage. Please see the latest post here: https://github.com/CoretechR/OMOTE/discussions/58

Another user also had WiFi issues with the main branch, which were gone with the branch. https://github.com/CoretechR/OMOTE/issues/38

So I'm wondering if this PR is really necessary. If you haven't already tried the branch, could you please do so?

mcurtiss1992 commented 3 months ago

I wasn't familiar with the new branch. I'll try it out! Thanks for a great project.

mcurtiss1992 commented 3 months ago

@KlausMu A switch to your "modular approach" branch fixed my connection issues. Thanks for the suggestion!

KlausMu commented 3 months ago

Memory optimization is now in main branch. You can directly use https://github.com/CoretechR/OMOTE