search

Corewala / Buran

Gemini browser for Android
GNU General Public License v3.0
107 stars 10 forks source link

fix android:lineHeight #29

Closed rudmannn closed 2 years ago

rudmannn commented 2 years ago

Hello,

I found you have used android:lineHeight in your app. It was introduced at API Level 28. It will not take any effects for low API levels.

I can reproduce the differences here.

API Level 29 2631659797271_ pic

API Level 27 2641659797758_ pic

You can change it to app:lineHeight as you did in https://github.com/Corewala/Buran/blob/2e4b70cec1c4c0e58032abde26e4b1efc519e965/app/src/main/res/layout/gemtext_code_block.xml#L37

The issues have gone on my side by this pull request.

Hope the information is useful for you