search

CoreyKaylor / Lightning.NET

.NET library for LMDB key-value store
Other
397 stars 82 forks source link

Testcases are missing a check in some places where LightningCursor.GetCurrent() is used #140

Closed bartwe closed 2 years ago

bartwe commented 3 years ago

A number of testcases like ShouldAdvanceKeyToClosestWhenKeyNotFound call GetCurrent() but do not assert the result.

CoreyKaylor commented 2 years ago

It does use the result. It destructures the result and only selects the key ignoring the other parts of the result. This is sufficient for the test. I reviewed all uses of GetCurrent and found similar outcomes. Let me know if there is a problem you see specifically that I've overlooked.