Closed DecoyFish closed 10 months ago
I've never used this function, but disregarding the return code doesn't seem like correct behavior. We should probably change it to throw on a failing return code.
Thanks, I've opened the following PR with the change and a test: #166
Thanks, PR is merged and sorry for the hiatus. I've had quite a lot going on in my personal life lately.
No worries. Thanks for maintaining this awesome project.
We've encountered a case in which a DB saved via LightningEnvironment.CopyTo was corrupted. Looking at the code, this method calls Lmdb.mdb_env_copy2, but doesn't appear to do anything with the returned result code. Is this by design (as there might be no viable way for this to fail), or should CopyTo return a MDBResultCode?