search

CoreyKaylor / Lightning.NET

.NET library for LMDB key-value store
Other
398 stars 82 forks source link

Respect NoSubDir flag; fixes issue #78 #80

Closed DanielAdolfsson closed 7 years ago

DanielAdolfsson commented 7 years ago

Just a check to make sure the NoSubDir flag isn't set.

DanielAdolfsson commented 7 years ago

You mean you think it should create the parent directory? Isn't that a bit outside what's expected of a library that deals with individual files though?

CoreyKaylor commented 7 years ago

@ilyalatt I'm not sure that's true. Mind adding more clarification to your thoughts?

CoreyKaylor commented 7 years ago

@DanielAdolfsson Not a big deal this time, but in the future it's a safer bet to send a PR from a branch that isn't master.

ilyalatt commented 7 years ago

Then why default behavior is creating directory that doesn't exist? I think that in both cases behavior should be equal.

CoreyKaylor commented 7 years ago

Yeah, I don't feel as strong about that behavior for this scenario.