Fixed copying native libraries into output directory

CoreyKaylor / Lightning.NET

.NET library for LMDB key-value store

Other

398 stars 82 forks source link

Fixed copying native libraries into output directory #93

Closed hey-red closed 7 years ago

hey-red commented 7 years ago

Fix #92

CoreyKaylor commented 7 years ago

Nice, I noticed this approach in another project and hadn't had time to digest. I was going to mention to handle the dylib on MacOS as well, but coreclr already loads the native libs from the package path. I haven't really bothered with mono due to historical challenges in general.

CoreyKaylor commented 7 years ago

Closed via rebase be15808

Thanks!

sebastienros commented 7 years ago

@CoreyKaylor side question. what do you mean by "closed via rebase". Should I understand that you didn't "merge" the PR but rebased the commits from one repository to the other?

hey-red commented 7 years ago

@CoreyKaylor I didn't check the work in mono. It's just a fix for full .NET.

CoreyKaylor commented 7 years ago

@sebastienros it means I rebased the PR on the latest master branch before merging. I mentioned it because the original PR came from @hey-red master branch so next time they pull from this remote it will cause issues.