Closed thdrbrkw closed 1 year ago
Looks good 👍 I just have 1 note and a question.
Looks good 👍 I just have 1 note and a question.
1. I would rename the frontend-draft folder in root in just frontend. 2. Why do we split in core ans lib and have a shared module? Do you intend to have a multilayered module structure? And when yes, why?
Yes, I can change the folder name. I followed the recommendation of https://angular.io/guide/styleguide#overall-structural-guidelines. I usually set up the Angular enviroment with different modules, but I'm also fine with putting everthing into one module. Haveing multiple modules is just what I'm used to.
Yes, I can change the folder name. I followed the recommendation of https://angular.io/guide/styleguide#overall-structural-guidelines. I usually set up the Angular enviroment with different modules, but I'm also fine with putting everthing into one module. Haveing multiple modules is just what I'm used to.
Ok :) I am fine with that. We just need to be consistent and follow this guidline then.
I just realised on cloning the folders shared and core should be inside the src/app folder. And following the guidelines there should be no lib module but inside app the dashboard and first-draft should be seperate modules. This would allow lazy loading if later down the road.
I did a pull request to this branch with a structure wich would follow the guidelines.
I merged Simon's PR into mine and did some additional renaming ('frontend-draft' into 'frontend')