CorgiTaco / Enhanced-Celestials

A Minecraft mod adding new Lunar Events such as Blood Moons!
GNU Lesser General Public License v3.0
41 stars 19 forks source link

[Bug]: Possible Incompatibility with Alloy Forgery #174

Closed Ultimushadow closed 2 months ago

Ultimushadow commented 10 months ago

Minecraft Version

1.19.2

Enhanced Celestials Version

1.20.1-5.0.0.2

Mod Loader

Fabric

Mod Loader Version

14.21/14.22

Bug Severity

Major

What happened?

Bug report does not allow me to select the correct MC version, but this crash occurs with the latest release on 1.20.1 Attempting to load both gives the attached crash, both work just fine without the other loaded. Mod versions:

latest.log

Crash: crash-2023-08-23_05.03.37-server.txt

Log: latest.log

Linguardium commented 2 months ago

issue is due to load timing with fabric api's dynamic registries. Mod was last updated before they existed and adds stuff to the vanilla registries during mod init, which can break if some other mod loads the registry class first. easy fix is for the dev to migrate to fabric api's dynamic registry system

CorgiTaco commented 2 months ago

Fixed for versions 5.0.0.3 and beyond!