CorgiTaco / Enhanced-Celestials

A Minecraft mod adding new Lunar Events such as Blood Moons!
GNU Lesser General Public License v3.0
41 stars 19 forks source link

[Bug]: Configurable Everything Incompatible #186

Open Treetrain1 opened 7 months ago

Treetrain1 commented 7 months ago

Minecraft Version

1.20.x

Enhanced Celestials Version

Latest

Mod Loader

Fabric

Mod Loader Version

0.15.0

Bug Severity

Major

What happened?

The problem resides with the ModifyConstant inside of your WorldRendererMixin.

ModifyConstant breaks if multiple mods try to modify the same thing. Such a breakage exists with this mod and Configurable Everything, but there could potentially be other mods that break.

A temporary solution is to just disable the mixins outright, which can be done via Configurable Everything’s mixins config, but I don’t know if it’s possible with this mod.

Solution:

A solution is to use Mixin Extras, an extension to Mixin that adds new annotations that provide better mod compatibility overall. Mixin Extras is included in Fabric Loader 0.15.0, so I would start with that. (But I don’t think it is included in forge so a manual dependency will probably be needed)

(By the way, using the ModifyExpressionValue and targeting CONSTANT will be the answer to solve it)

If you aren’t sure how to solve this, I’ll be happy to open a PR.

latest.log

I don’t think logs are necessary here, i think i explained everything.