CorgiTaco / Enhanced-Celestials

A Minecraft mod adding new Lunar Events such as Blood Moons!
GNU Lesser General Public License v3.0
41 stars 19 forks source link

[Bug]: Harvest Moon duplicates placed seeds. #208

Open MynxOne opened 3 weeks ago

MynxOne commented 3 weeks ago

Minecraft Version

1.20.1

Enhanced Celestials Version

1.20.1-5.0.0.4

Mod Loader

Forge

Mod Loader Version

47.3.0

Bug Severity

Major

What happened?

During the harvest moon (and presumably scaling during the super harvest moon), seeds placed can just be broken again for two seeds. With Pam's HarvestCraft 2, this enables duplication of crops to direct plant drops. This issue works with default vanilla crops as well. A datapack made was also ignored, altering the bonus value for the moon to 0 in order to bypass.

MynxOne commented 3 weeks ago

A found datapack fixed it, sorry for reporting!

DarianLStephens commented 3 weeks ago

What datapack? Don't just leave us hangin'!

MynxOne commented 3 weeks ago

At first, I tried a datapack consisting of only amendments to harvest and super harvest moons. It didn't seem to work. Then I tried a reload schedule with a variety of changes and this resulted in the values remaining the same minus the value of:

"#enhancedcelestials:harvest_moon_crops":

Which is default 1, which doubles the seed drop count no matter what stage the crop is grown at. If yo uremove the data section containing this value, the server-side will not boot as the datapack causes a load crash. Otherwise, amending the value is a workaround.

MynxOne commented 3 weeks ago

My conclusion: The harvest moon (including super variant) does not check crop growth percentage when harvesting.

StrikerDeer commented 1 week ago

Do you have a link to a download of the datapack?

MynxOne commented 1 week ago

I ended up making a custom one! Hope this helped: EnhancedCelestialsFix.zip

StrikerDeer commented 1 week ago

Thanks!