search

CorkHQ / Cork

A fast, platform-agnostic and minimal bootstrapper for Roblox and Roblox Studio
zlib License
35 stars 3 forks source link

Fix settings.cpp #35

Closed Kaydax closed 1 year ago

Kaydax commented 1 year ago

settings.cpp was missing an include causing builds to fail

Bugadinho commented 1 year ago

Not sure how this worked before the include, but this seems fine to merge as long as the changes to .gitignore are removed.

Kaydax commented 1 year ago

The changes to the gitignore are there because cmake under programs like Visual Studio Code generate a .cache folder when building / opening the project. I added it because I don't think people would like to push their .cache folder to the repo. If you want me to remove it I can, but I dont see any issues in keeping it either

Bugadinho commented 1 year ago

Well, that makes sense, while it didn't create a .cache folder for me, it might for others depending on installed extensions, no harm in including it.