CorneliusMa / SilkSpawners_v2

SilkSpawners - A Minecraft plugin to make Spawners mineable
https://www.spigotmc.org/resources/silkspawners-versions-1-8-8-1-18-2.60063/
MIT License
14 stars 10 forks source link

spawners turning pig #15

Closed pump61 closed 2 years ago

pump61 commented 2 years ago

Spawners are turning pig when placed on the ground

RealFinePoint commented 2 years ago

I'm also having this issue, specifically for bedrock players after clicking soon after it's placed.

CorneliusMa commented 2 years ago

I'm currently very busy, but will fix this asap

frankinbaka commented 2 years ago

Really, and still not fixed, even after almost 1 month :c

CorneliusMa commented 2 years ago

I can't reproduce your problem. Have you set the correct permissions and are you using spigot/paper?

frankinbaka commented 2 years ago

Yes yes, simply the spawners of the players that were stored in the chests, when they take it to put it in the chosen place, it simply turns into a pig.

Yes, I use spigot/paper

RealFinePoint commented 2 years ago

I'm still having this problem, but specifically for Bedrock players (via Geyser) who click too fast after placing it. It sounds like a different issue than what OP is complaining about.

PedroMPagani commented 2 years ago

@CorneliusMa I'm having this issue too, we're running 500 players online (DonutSMP), and at least 300 of those are bedrock users, almost all the reports came from bedrock players.

PedroMPagani commented 2 years ago

I'll debug your code and implement it in the server, if I get any good info I'll do a PR, sounds good?

PedroMPagani commented 2 years ago

Yeah, so here's the logs:

07/10/2022 10:10:52 User T0R8EN broke a spawner PIG at 2171 07/10/2022 10:10:54 User T0R8EN placed a spawner PIG at 2171

When the user breaks it, the entity type is PIG for some reason.

PedroMPagani commented 2 years ago

Hey, so I figured what the issue is.

[10:50:51 INFO]: Entity type: CREEPER itemStack: ItemStack{AIR x 0, UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"light_purple","text":"Spawner"}],"text":""}, lore=[{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"yellow","text":"Creeper"}],"text":""}]}}
[10:50:51 INFO]: [SPAWNER CHANGE]
[10:50:51 INFO]: Entity type: PIG itemStack: ItemStack{SPAWNER x 1, TILE_ENTITY_META:{meta-type=TILE_ENTITY, display-name={"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"light_purple","text":"Spawner"}],"text":""}, lore=[{"extra":[{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"yellow","text":"Pig"}],"text":""}], blockMaterial=SPAWNER}}
PedroMPagani commented 2 years ago

Basically if the player clicks too fast, the PlayerInteractEvent in the SpawnerChange cancells and sets the spawner to pig, I'll make a PR for it.

PedroMPagani commented 2 years ago

The pr was sent some time ago, if you could merge it @CorneliusMa

CorneliusMa commented 2 years ago

Hi @PedroMPagani Thanks a lot for your help, I will take a look at the pr

RealFinePoint commented 2 years ago

Was this merged?

CorneliusMa commented 2 years ago

Just merged it