search

CornellCustomDev / cwd_base

A lightweight Drupal 8+ theme, implementing Cornell Branding and standard CWD components.
1 stars 2 forks source link

Gallery on basic page #33

Closed alisonjo315 closed 3 years ago

alisonjo315 commented 3 years ago

Addresses #4 on https://github.com/CU-CommunityApps/CD-demo/issues/93

(also removes code related to metadata fields that don't exist on CD Demo -- they were there from when the template was copied in from the CTI site)

alisonjo315 commented 3 years ago

@ama39 As a starting place, for how gallery is rendered when not a full page display:

As mentioned in my commit message, this change does not include a display suitable for a list of galleries, but we don't have a list of galleries, so that's all right -- but, heads-up! (P.S. There is a view of gallery teasers on CTI, but it's not actually in use / they don't have any gallery nodes.......)

QUESTION: Should I keep the linked gallery node title...? I can see reasons to keep it and reasons to exclude it. I'd like to just, pick one option, and we can change it later if we feel like it -- just need galleries to work on basic pages on Bright Beams ASAP 😁 So, lmk what you think! Thanks!

alisonjo315 commented 3 years ago

Review on "updates" multidev of CD Demo: https://updates-cd-demo.pantheonsite.io/sample-page-embedded-gallery

(vs main CD Demo dev site: https://dev-cd-demo.pantheonsite.io/sample-page-embedded-gallery

alisonjo315 commented 3 years ago

Yikes did I ever mess up this PR 🤦 Oy vey.