CornellCustomDev / cwd_base

A lightweight Drupal 8+ theme, implementing Cornell Branding and standard CWD components.
1 stars 2 forks source link

Template and styles for inline oembed videos #70

Open alisonjo315 opened 1 year ago

alisonjo315 commented 1 year ago

We're switching from video_embed_field to Drupal core "oembed" functionality for YouTube videos: https://github.com/CU-CommunityApps/cd_drupal_upstream/issues/42

Accompanying tasks for our Drupal base theme -- can happen any time (no need to wait for the cd_drupal_upstream issue to be complete):


FWIW: This work is already happening on VPUE (as of 2023-09-13, the oembed field template is done, the style rule will be done soon).

alisonjo315 commented 11 months ago

Aspect ratio issue on d.o is still open, but when I put videos on the under-development CLASSE site, they seem okay?? -- bottom of this demo page: https://dev-classe.pantheonsite.io/about

alisonjo315 commented 7 months ago

Part 1 (new field template) is done and merged (#77). Per my comment in December, it's possible that part 2 is not necessary, I'm really not sure 🤷‍♀️

Edit: Then I added "part 3" this evening -- but maybe that doesn't need to happen on CD Demo itself........