Open alisonjo315 opened 1 year ago
Aspect ratio issue on d.o is still open, but when I put videos on the under-development CLASSE site, they seem okay?? -- bottom of this demo page: https://dev-classe.pantheonsite.io/about
Part 1 (new field template) is done and merged (#77). Per my comment in December, it's possible that part 2 is not necessary, I'm really not sure 🤷♀️
Edit: Then I added "part 3" this evening -- but maybe that doesn't need to happen on CD Demo itself........
We're switching from video_embed_field to Drupal core "oembed" functionality for YouTube videos: https://github.com/CU-CommunityApps/cd_drupal_upstream/issues/42
field--field-media-oembed-video.html.twig
is already in use on that multidev)Accompanying tasks for our Drupal base theme -- can happen any time (no need to wait for the cd_drupal_upstream issue to be complete):
field--field-media-oembed-video.html.twig
-- simply to use_field--less-wrapped.html.twig
(same as field--image.html.twig).FWIW: This work is already happening on VPUE (as of 2023-09-13, the oembed field template is done, the style rule will be done soon).