update to use iter_utterances instead of accessing private variables

CornellNLP / ConvoKit

ConvoKit is a toolkit for extracting conversational features and analyzing social phenomena in conversations. It includes several large conversational datasets along with scripts exemplifying the use of the toolkit on these datasets.

https://convokit.cornell.edu/documentation/

MIT License

556 stars 129 forks source link

update to use iter_utterances instead of accessing private variables #170

Closed oscarso2000 closed 2 years ago

oscarso2000 commented 2 years ago

Description

Minor issue that never got changed since issue #140 was closed: politenessStrategies.py and textProcessor.py accesses private variable corpus.utterances in line 79 and line 55 respectively, and i remember mentioning that code should not access corpus private variables outside of the corpus file and should use the getters instead like corpus.iter_utterances().

oscarso2000 commented 2 years ago

Am I the only one getting issues with emoji?

oscarso2000 commented 2 years ago

Found issue of cleantext not being updated with newest version of emoji.