CornellNLP / ConvoKit

ConvoKit is a toolkit for extracting conversational features and analyzing social phenomena in conversations. It includes several large conversational datasets along with scripts exemplifying the use of the toolkit on these datasets.
https://convokit.cornell.edu/documentation/
MIT License
556 stars 129 forks source link

Drop support for Python 3.6 #171

Closed calebchiam closed 2 years ago

calebchiam commented 2 years ago

Description

Python 3.6 has reached its end of life, meaning packages in general will stop making updates to support it. We should accordingly drop support as well, as maintaining support for Python 3.6 will lead to dependency issues as other packages drop support for it.

This has already happened for our clean-text dependency: https://github.com/CornellNLP/ConvoKit/pull/170#issuecomment-1186366428.

Motivation and Context

Further context re: clean-text

As of v0.6.0, clean-text actually correctly sets its requirements to an older version of emoji. However, right now, when running the 3.6 workflow, it attempts to install v0.5.0 instead, which installs the latest emoji (aka 2.0.0). The reason it does this is because v0.6.0 does not support Python 3.6, as of 6 months ago, which coincides with the end-of-life date for Python 3.6.

In other words, the Python 3.6 workflow failure can only be fixed if we update the lowest Python version for ConvoKit to 3.7, so it uses an up-to-date version of clean-text

How has this been tested?

Workflow tests.