Closed leplatrem closed 7 months ago
Thanks for your feeback @jenstroeger! really appreciated!
particular some of the git hooks we use for checking code 🤓
I'm not a big fan of mandatory pre-commit hooks, I would be in favor of letting devs do that on their own
A few thoughts:
- Add a CODEOWNERS file.
👍
Add a SECURITY policy file.
👍
Have you considered formatting with black?
We do it with ruff
already 😉
The goal of this PR is to reduce the amount of efforts related to maintenance. This repository is very low in our pile of things we maintain, and removing manual work for releasing is a tiny improvement. I'm wondering whether we should add a warning/disclaimer about this best effort maintenance in an issue template or something....
@leplatrem still seeing errors with CODEOWNERS file:
Unknown owner on line 1: make sure the team @Cornices/cornice exists, is publicly visible, and has write access to the repository
* @Cornices/cornice
master
tomain
Things lost with this PR: