fix log encoding detect

Corona-Studio / ProjBobcat

The next generation Minecraft launcher core written in C# providing the freest, fastest and the most complete experience.

https://kb.corona.studio/zhCN/projbobcat/

MIT License

159 stars 21 forks source link

fix log encoding detect #126

Closed laolarou726 closed 7 months ago

laolarou726 commented 7 months ago

PR-Codex overview

This PR focuses on enhancing encoding handling, adding a new property to a model, and improving game version resolution helpers.

Detailed summary

Added System.IO import in EncodingHelper.cs
Added ClientVersion property to RawVersionModel
Improved encoding handling in DefaultLogAnalyzer.cs
Added TryGetMcVersionByClientVersion method in GameVersionHelper
Updated error handling in GameResourcesResolveHelper

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

yueyinqiu commented 7 months ago

I'm now wondering whether GuessEncoding method could work as expected.

Does it relies on BOM? And will decoding the string in UTF8 in advance break some things?

yueyinqiu commented 7 months ago

Meanwhile, is utf7 really used in some cases? If not, I recommend to remove the related codes, since UTF7 is obsolete.

laolarou726 commented 7 months ago

I'm now wondering whether GuessEncoding method could work as expected.

Does it relies on BOM? And will decoding the string in UTF8 in advance break some things?

pretty sure its working