Closed tal-nc closed 4 years ago
@tal-nc Can you attach a result json file for example?
I think it's a great solution, we just need to switch rv_discrete to choice and it will look much better. I think that we should switch our ugly format with this and add an option to import this format.
Is there a way to get rid of :
Is there a way to get rid of :
not that i know of
we need a better export to the consts files than we currently have (hard-coping the parameters files). this should do, however i am not sure that it is perfect either. the picklejson extracts a bit too much information. mainly rv_discretes are VARY annoying in this aspect. i am not using regular json export since it can't handle complex objects. the matrix_consts and circles_consts are great, but the simulation_consts comes out a bit too long.
note that this also adds a dependency to the project, i added it to the requirements.txt, let me know if it needs to be added elsewhere.
i think this is good enough, but i would like to hear your opinion.
we also need to create a base class for all the consts, but that's for another conversation.