search

CoronaTeam / CoronaGame

Software Development Project 2020
3 stars 0 forks source link

Dev/new store last positions #196

Closed TheCrazyKing closed 4 years ago

TheCrazyKing commented 4 years ago

This enable the persistency of the senderCache.

TheCrazyKing commented 4 years ago

I don't have anything to say regarding the code itself but I wonder if it's the right class for this functionality.

I view this class as a fancy wrapper around the firestoreInteractor but sending data to a .csv still fit the name

Still accepting !

Yes, but actually it's much simpler as it is now. But wait. Something I can do is having the getLastPositions in the dataReceiver.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 67938f4f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 44.1% (80% is the threshold).

This pull request will bring the total coverage in the repository to 83.8% (-0.2% change).

View more on Code Climate.

TheCrazyKing commented 4 years ago

I will increase the test coverage