CoronaWhy / task-geo

"Help us understand how geography affects virality."
MIT License
10 stars 20 forks source link

Fix cds datasource #47

Closed ManuelAlvarezC closed 4 years ago

ManuelAlvarezC commented 4 years ago

Description

Changes wrong values on aggregate columns for rows with state value but no value on state, now region column. Add tests for dataset validator. Fix open issue with the validator.

Fixes #41 Fixes #44

Checklist:

DanielRobertNicoud commented 4 years ago

In main.py the argument of the function should be country="Italy". As it is currently, it returns an empty dataset.

IMO, the connector should optionally take a list of countries, not a single country.

The argument should be ISO-2 (to be fixed later on).