Open cgomez9 opened 4 years ago
I created the test to check the dataset format but it was failing and its a problem with columns "county" and "state" that are not taking into consideration. I believe the dataset has a correct format, I tried to improve the tester but I don't want to break something. What should I do? @ManuelAlvarezC
Hi @cgomez9, and thanks for your submission.
The issue you mention is caused because you are not following the Data Model. Basically, state
column should be renamed to region
and county
to sub_region
.
Please fix it, and I'll review the rest of the submission
Also, when you fix all this, find a way to delete from the git history the fixture and long notebook you included, as git includes the history it will make the repository unnecesary large and slow.
I made all the requested changes, waiting for #62 to resolve.
Description
A rework was made of the US Census module. Previously a zip file was downloaded and processed, now we get the dataset directly from an API in JSON format. Also a new common file was included with FIPS codes of all states and counties of USA.
Fixes #37
Checklist: