search

Corosauce / WATUT

What Are They Up To - Minecraft Forge Mod
22 stars 5 forks source link

I changed my config but it didn't work #44

Open ninjaguardian opened 1 month ago

ninjaguardian commented 1 month ago

Describe the bug I was looking at https://github.com/Corosauce/WATUT/issues/8 and I followed the instructions but it did not work.

(also by the way there is a typo in this template arent is spelled aren't)

To Reproduce

  1. Go to watut-client.toml
  2. showIdleStatesInPlayerList = false
  3. Launch game with better ping display
  4. Crash

latest.log, debug.log or crash report if the other 2 arent possible https://mclo.gs/4yihQ7C

Expected behavior It should disable the feature and not crash

Mod and Minecraft version:

ninjaguardian commented 3 weeks ago

When showIdleStatesInPlayerList is false, renderPingIconHook returns false. When renderPingIconHook is false, renderPingIcon renders the icon. So it is wrong.

src/main/java/com/corosus/watut/mixin/client/RenderPingIconInject.java line 23 does 

if (!WatutMod.getPlayerStatusManagerClient().renderPingIconHook((PlayerTabOverlay)(Object)this, pGuiGraphics, p_281809_, p_282801_, pY, pPlayerInfo)) {…}

but it should do

if (WatutMod.getPlayerStatusManagerClient().renderPingIconHook((PlayerTabOverlay)(Object)this, pGuiGraphics, p_281809_, p_282801_, pY, pPlayerInfo)) {…}

But, of course, I could be wrong.