search

Corosauce / weather2

Minecraft Forge Mod - Localized Weather - A rewrite of weather & tornados with a focus on localized storm systems
Other
148 stars 77 forks source link

Optifine Fix Here! #514

Closed ExtraJackGuest closed 1 year ago

ExtraJackGuest commented 1 year ago

Here is The New Optifine Fixed By Me Here Is The Link! [link removed by admin]

ProfessorFartsalot commented 1 year ago

I do not see anything that is fixed? This appears to just be Optifine 1.18.2's preview H9 release.

Edit: It does load in and shaders work, but one could just use the preview download of optifine right? Or have I missed something?

ExtraJackGuest commented 1 year ago

I do not see anything that is fixed? This appears to just be Optifine 1.18.2's preview H9 release.

Edit: It does load in and shaders work, but one could just use the preview download of optifine right? Or have I missed something?

because optifine would crash with the weather2 mod!

ProfessorFartsalot commented 1 year ago

I've never had it happen using the preview optifine H9 release. Just the text is blurry.

ProfessorFartsalot commented 1 year ago

For reference, I used Optifine HD U H9 pre2 with no crashes with weather2 2.7.1

ProfessorFartsalot commented 1 year ago

So I decided to investigate this, Javacomp says all you changed was META-INF/mods.toml and edited the name of the mod as well as removed credits to the original devs. Care to explain yourself?

image

image

Edit: added javacomp output showing modified files at the top

CitiesXL2815 commented 1 year ago

dude report bugs, crashes and Suggestion, this github is for weather2 not optifine, optifine breaks modding, and beta testing should be without optifine/shaders, plus Optifine is hot garbage when it comes to Modded, all dev's do not want to support optifine anyways

ProfessorFartsalot commented 1 year ago

This isn't even about optifine, he literally took a preview download and then tried to steal credit for making it when he's done absolutely no code changes. Javacomp shows all modified class files and there was no code changes here.

Optifine is closed source, and I'm sure the devs would not be happy to have someone redistributing it as their "patch". That like violates almost every term of Optifine's services.

Corosauce commented 1 year ago

Yeah if its just the same as their preview version on their own site, should just go there, good investigation into whats actually changed, ty.