Corosauce / weather2

Minecraft Forge Mod - Localized Weather - A rewrite of weather & tornados with a focus on localized storm systems
Other
148 stars 77 forks source link

Help! Configs keep Resetting #527

Closed MrSquigles closed 1 year ago

MrSquigles commented 1 year ago

21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Configuration file C:\Users\Drax-Bot\Desktop\Storm of Hell\config\Weather2\Storm.toml is not correct. Correcting [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general was corrected from null to its default, SimpleCommentedConfig:{}. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_OddsTo1OfHighWindWaterSpout was corrected from null to its default, 150. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_FlyingBlocksHurt was corrected from null to its default, true. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_MaxPerPlayerPerLayer was corrected from null to its default, 20. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Deadly_CollideDistance was corrected from null to its default, 128. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_LightningStrikeBaseValueOddsTo1 was corrected from null to its default, 200. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_NoRainVisual was corrected from null to its default, false. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_MaxRadius was corrected from null to its default, 300. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_AllTypes_TickRateDelay was corrected from null to its default, 60. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_WaterBuildUpRate was corrected from null to its default, 10. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_WaterSpendRate was corrected from null to its default, 3. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_WaterBuildUpOddsTo1FromSource was corrected from null to its default, 15. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_WaterBuildUpOddsTo1FromNothing was corrected from null to its default, 100. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_WaterBuildUpOddsTo1FromOvercastRaining was corrected from null to its default, 30. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_TemperatureAdjustRate was corrected from null to its default, 0.1. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_HailPerTick was corrected from null to its default, 10. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_OddsTo1OfOceanBasedStorm was corrected from null to its default, 300. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_OddsTo1OfLandBasedStorm was corrected from null to its default, -1. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_HighWind was corrected from null to its default, 90. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_Hail was corrected from null to its default, 80. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F0_Tornado was corrected from null to its default, 70. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C0_Cyclone was corrected from null to its default, 70. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F1_Tornado was corrected from null to its default, 50. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C1_Cyclone was corrected from null to its default, 50. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F2_Tornado was corrected from null to its default, 40. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C2_Cyclone was corrected from null to its default, 40. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F3_Tornado was corrected from null to its default, 30. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C3_Cyclone was corrected from null to its default, 30. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F4_Tornado was corrected from null to its default, 20. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C4_Cyclone was corrected from null to its default, 20. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_F5_Tornado was corrected from null to its default, 10. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_PercentChanceOf_C5_Cyclone was corrected from null to its default, 10. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_ParticleSpawnDelay was corrected from null to its default, 3. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Player_Storm_Deadly_OddsTo1 was corrected from null to its default, 30. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Player_Storm_Deadly_TimeBetweenInTicks was corrected from null to its default, 72000. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Server_Storm_Deadly_UseGlobalRate was corrected from null to its default, false. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Server_Storm_Deadly_OddsTo1 was corrected from null to its default, 30. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Server_Storm_Deadly_TimeBetweenInTicks was corrected from null to its default, 72000. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.preventServerThunderstorms was corrected from null to its default, true. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Lightning_OddsTo1OfFire was corrected from null to its default, 20. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Lightning_lifetimeOfFire was corrected from null to its default, 3. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Lightning_DistanceToPlayerForEffects was corrected from null to its default, 256. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Lightning_StartsFires was corrected from null to its default, false. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Deflector_RadiusOfStormRemoval was corrected from null to its default, 150. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Deflector_MinStageRemove was corrected from null to its default, 1. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Deflector_RemoveRainstorms was corrected from null to its default, false. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Deflector_RemoveSandstorms was corrected from null to its default, true. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_Overcast_Amount was corrected from null to its default, 0.01. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_Overcast_OddsTo1 was corrected from null to its default, 50. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_OddsTo1 was corrected from null to its default, 150. [21:04:29] [modloading-worker-0/WARN] [ne.mi.co.ForgeConfigSpec/CORE]: Incorrect key general.Storm_Rain_TrackAndExtinguishEntitiesRate was corrected from null to its default, 200.

ProfessorFartsalot commented 1 year ago

Edit your configs with notepad++ and save them in ANSI or UTF-8. I've already opened an issue over on TheElectronWill/Night-Config about this and they're aware that windows notepad defaults to include BOM headers which results in invalid configs.

ProfessorFartsalot commented 1 year ago

Might also help to use Minecraft's mod configuration menu.

HonzaVinCZ commented 1 year ago

Edit your configs with notepad++ and save them in ANSI or UTF-8. I've already opened an issue over on TheElectronWill/Night-Config about this and they're aware that windows notepad defaults to include BOM headers which results in invalid configs.

I think you're wrong. I edit all my config files in Sublime Text and all config files are functional except the weather2. It just keeps resetting all weather2 config files to default randomly. One time it lasts for three server restarts, other time it lasts just until next server restart. Let's just wait for @Corosauce to make conclusion.

Duplicates https://github.com/Corosauce/weather2/issues/503 https://github.com/Corosauce/weather2/issues/529 https://github.com/Corosauce/weather2/issues/520

ProfessorFartsalot commented 1 year ago

Edit your configs with notepad++ and save them in ANSI or UTF-8. I've already opened an issue over on TheElectronWill/Night-Config about this and they're aware that windows notepad defaults to include BOM headers which results in invalid configs.

I think you're wrong. I edit all my config files in Sublime Text 3 and all config files are functional except the weather2. It just keeps resetting all weather2 config files to default randomly. One time it lasts for three server restarts, other time it lasts just until next server restart. Let's just wait for @Corosauce to make conclusion.

Duplicates #503 #529

If you think I'm wrong, please see @TheElectronWill/night-config/issue/67 .

Edit: wording, reee

ProfessorFartsalot commented 1 year ago

Notepad++ fixed my issue which is why I closed it on this repo.

HonzaVinCZ commented 1 year ago

Notepad++ fixed my issue which is why I closed it on this repo.

I don't think bugs are fixed like "Hey, download other program to fix bug that is only related to my mod.". Like you should not force users of your code to use specific program to make possible something simple as change config. If it works for literally every other mod, there must be a way how mod dev can improve his own code to allow users to make something easy as edit configs without any uneccessary difficulties. Just talking for another one million people that since 1.12 downloaded this mod. World configs are all .toml files as well and they are fully functional on my server although they are mostly edited as well.

There is no reason to further discuss this issue without Coro. He is the mod developer and he says if something will be done or not about this.

Edit: My config files in Sublime Text are automatically saved with UTF-8 encoding. I couldn't find any changelog related to this bug since 2.7.1 so I keep this as still actual. Tested with 2.7.1.

ProfessorFartsalot commented 1 year ago

Please post your config file over on the issue I linked, as TheElectronWill can look at it. He made NightConfig which is used by minecraft forge and I think this should be taken up with him and not corosauce as forge uses nightconfig to read the .toml file.

ProfessorFartsalot commented 1 year ago

In fairness, I agree that issues should not be fixed by other programs, but I'm telling you what the person who made the config system for forge told me, not what I think solves the problem. If you comment on the issue, the developer can add support for your editor.

Edit: Check if you have Byte order marks in your config file. If this is the case, no matter what you do, this issue cannot be resolved by corosauce. You have to report your issue to the forge repo. https://en.wikipedia.org/wiki/Byte_order_mark

If there is no BOM in your file, then fair enough; this is an issue coro will have to fix.

HonzaVinCZ commented 1 year ago

In fairness, I agree that issues should not be fixed by other programs, but I'm telling you what the person who made the config system for forge told me, not what I think solves the problem. If you comment on the issue, the developer can add support for your editor.

Edit: Check if you have Byte order marks in your config file. If this is the case, no matter what you do, this issue cannot be resolved by corosauce. You have to report your issue to the forge repo. https://en.wikipedia.org/wiki/Byte_order_mark

If there is no BOM in your file, then fair enough; this is an issue coro will have to fix.

I'm quite sure there is no BOM because my config files were saved with UTF-8 by default. I would have to select manually "UTF-8 with BOM" to have wrong encoding.

image

ProfessorFartsalot commented 1 year ago

If it is of no trouble, are you able to post the affected config files so that I can test them for you on my server with just weather2 and coroutil to confirm?

HonzaVinCZ commented 1 year ago

If it is of no trouble, are you able to post the affected config files so that I can test them for you on my server with just weather2 and coroutil to confirm?

Weather2 Configs.zip Same config files that are used on my server and resetted each time randomly.

ProfessorFartsalot commented 1 year ago

Thank you. Give me a moment and I'll check with them.

ProfessorFartsalot commented 1 year ago

Okay, so I tried a few different methods to get your configs to work, and while they worked the first server start stop cycle, they did not work the next.

I reached out to Mrbt0907 who said that it's likely the variables were incorrectly defined. As such, I will also be reopening my issue #520 .