Corosauce / weather2

Minecraft Forge Mod - Localized Weather - A rewrite of weather & tornados with a focus on localized storm systems
Other
151 stars 77 forks source link

Problem with sky in 1.18.2 #555

Open Lozf opened 1 year ago

Lozf commented 1 year ago

Using optifine HD U 9 pre2 version, during rainstorms/snowstorms, ect the sky never fully darkens. Also using forge 40.2.0 and the latest version of mods, along with complementary shaders. Are there settings you could recommend that might help with this?

2023-03-06_19 10 55 2023-03-06_19 10 31

I also turned wind_particle_leaves to false, but still have stuff flying in the lighter winds, is there a config I am missing to turn that off?

Pinecone6442 commented 1 year ago

same problem

ProfessorFartsalot commented 1 year ago

Have you tried the latest update which reversed this change?

Lozf commented 1 year ago

Yup, I have the latest update. Hail and lightning storms darken very slightly, everything else is like the sky picture above. Also, snow only appears on the ground during snowstorms if I turn the weather to snow while weather2 snow storm is active. Otherwise, no snow accumulates.

ProfessorFartsalot commented 1 year ago

This should be fixed in the latest 1.18 update. See pull request #522 .

Lozf commented 1 year ago

Would it be possible to get a config option to change the darkness levels in the new update? That way those who have shaders or want more dramatics can change it, the way they were discussing in 522?

Pinecone6442 commented 1 year ago

hey guys just set Storm_Rain_Overcast_Amount to 1.0

Lozf commented 1 year ago

I just tried this, it doesn't change anything regarding light and the sun- unlike what happens with tornadoes where the sun disappears and the sky darkens.

ProfessorFartsalot commented 1 year ago

Are you trying to get things like Complementary to cover the sky completely and adjust the rain and fog to be realistic like it would in vanilla when a thunderstorm is ongoing?

Lozf commented 1 year ago

Yes, exactly! Are there some settings I can adjust to achieve this?

ProfessorFartsalot commented 1 year ago

Okay yeah 2.7.5 does it to max intensity by default and 2.7.4 does not. I'll see if I can suggest this to Coro, but at the moment he's working on non-Java projects that take priority so it may be a while before my suggestion reaches him ^^

Lozf commented 1 year ago

Okay, Thank you! I just checked I am using the weather2-1.18.2-2.7.5 version, so does this mean it should be doing that for rainstorms already?

ProfessorFartsalot commented 1 year ago

It should be doing that already for severe storms, maybe not rain since I believe the math involves multiplying the rain and thunder both by the darkness value (1.0 as of the new update)

Pinecone6442 commented 1 year ago

Yeah the overcast thing only works on 1.12

ProfessorFartsalot commented 1 year ago

This is correct as if you look at my pull request you can see the visual darkness amplifier is hard coded.