CorpGlory / grafana-graph-panel

Webpack copy of Grafana default panel
MIT License
11 stars 5 forks source link

Graph Panel new features #9

Closed npechl closed 5 years ago

npechl commented 5 years ago

I am trying to build a Grafana plugin based on your plugin.

I would like to add the new features of the graph panel (Time region selection and Rendering a dot when no connecting line can be made). I have added all the necessary files but when i try to use my plugin the following error comes up:

time region error

I believe this is because the following file is being imported into time_region_manager.ts:

grafana new features

If you have any idea what is the right configuration to fix my problem, please let me know! Any help would be very appreciated!

rozetko commented 5 years ago

Hey, @nikopech! It's a known problem with this plugin Which is fixed in one of our forks: https://github.com/CorpGlory/grafana-multibar-graph-panel by those 2 PRs: https://github.com/CorpGlory/grafana-multibar-graph-panel/pull/15 https://github.com/CorpGlory/grafana-multibar-graph-panel/pull/17 Which can be applied here with just a couple of changes (related to plugin name)

marefr commented 5 years ago

time_region_manager.ts are very similar to threshold_manager.ts. Think you need to change the import like done in threshold_manager.ts, see code.

npechl commented 5 years ago

@rozetko @marefr Thank you both for the replies. Changing the import seems to fix the problem.