Time labels shift - Githubissues

rozetko commented 6 years ago

Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8) Current behaviour: Expected behaviour: @nsayedqt, am I right? Is it the expected behaviour?

nsayedqt commented 6 years ago

Yes that is correct

Regards, Nausheen Sayed Product Owner, QTDashboard

From: rozetko notifications@github.com Sent: Wednesday, October 10, 2018 2:25:22 PM To: CorpGlory/grafana-multibar-graph-panel Cc: Nausheen Sayed; Mention Subject: [CorpGlory/grafana-multibar-graph-panel] Time labels shift (#22)

Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8) Current behaviour: [image]https://user-images.githubusercontent.com/1989898/46752042-e0aeab80-ccc4-11e8-9d73-d22b146bff9a.png Expected behaviour: [image]https://user-images.githubusercontent.com/1989898/46752077-f6bc6c00-ccc4-11e8-8cb0-c3141efddcb2.png @nsayedqthttps://github.com/nsayedqt, am I right? Is it the expected behaviour?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/CorpGlory/grafana-multibar-graph-panel/issues/22, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV9JvlfJEf0vP6z9hMqkIJ6o940jIyXlks5ujjuSgaJpZM4XWDm8.

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this E-mail. Please notify the sender immediately by E-mail if you have received this E-mail by mistake and delete this E-mail from your system.

E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message or attached documents or for any damage suffered by your computer system caused by any errors or viruses contained in the E-mail message or any attached documents. QualiTest Group may monitor email traffic data.

nsayedqt commented 6 years ago

Also when I hover over the bars, the dates displayed are wrong. The data is organized or pointing to 10/8, 10/15, 10/22 but both the axes and hovering shows wrong dates. I am using MYSQL data source.

From: rozetko notifications@github.com Sent: Wednesday, October 10, 2018 2:25 PM To: CorpGlory/grafana-multibar-graph-panel grafana-multibar-graph-panel@noreply.github.com Cc: Nausheen Sayed nsayed@qualitestgroup.com; Mention mention@noreply.github.com Subject: [CorpGlory/grafana-multibar-graph-panel] Time labels shift (#22)

Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8) Current behaviour: [image]https://user-images.githubusercontent.com/1989898/46752042-e0aeab80-ccc4-11e8-9d73-d22b146bff9a.png Expected behaviour: [image]https://user-images.githubusercontent.com/1989898/46752077-f6bc6c00-ccc4-11e8-8cb0-c3141efddcb2.png @nsayedqthttps://github.com/nsayedqt, am I right? Is it the expected behaviour?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/CorpGlory/grafana-multibar-graph-panel/issues/22, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV9JvlfJEf0vP6z9hMqkIJ6o940jIyXlks5ujjuSgaJpZM4XWDm8.

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this E-mail. Please notify the sender immediately by E-mail if you have received this E-mail by mistake and delete this E-mail from your system.

E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message or attached documents or for any damage suffered by your computer system caused by any errors or viruses contained in the E-mail message or any attached documents. QualiTest Group may monitor email traffic data.

rozetko commented 6 years ago

We're implementing it now Going to generate labels by groups amount (if there are not much of groups - every group would have a label, if there are too many groups - every nth of them would be skipped) For example:

groups here are big enough - we can put label under each of them
but groups here are too small - we would skip label under every 2nd one

nsayedqt commented 6 years ago

Assuming the groups will have option for weekly grouping? Will it also resolve the issue with dates upon hovering on the bars (currently it is not showing correct date)?

rozetko commented 6 years ago

Hey, @nsayedqt

Let me make it clear: Grouping is based on datasource response. Plugin doesn't transform data. It is something datasource should handle.

Suppose you have such dataset: It is displayed like this:

Also, you can test it here: http://grafana5.corpglory.com/d/r7Zvhi1ik/multibar User: guest Password: tx8yM

I believe you got your data already grouped by MySQL, so that should work in your case.

P.S. Could you please create another issue for tooltips? It would be nice to have more info on it (i.e. tooltip screenshots)

nsayedqt commented 6 years ago

looks right in your environment, but i need to test in mine. Where can i download the latest code?

nsayedqt commented 6 years ago

@rozetko ok lets try this again: This is my query result:

this is my graph - x axes ticks are not pointing to correct dates and when i hover over it shows wrong dates as well

my data is grouped correctly, query is correct but display is wrong I hope i am able to convey my issue

rozetko commented 6 years ago

I'll make a release in half an hour and let you know About tooltip: seems like timezone problem. What timezone is set in your dashboard? Seems like UTC

nsayedqt commented 6 years ago

its default timezone which i guess is UTC

rozetko commented 6 years ago

@nsayedqt you can install new version as you always do:

cd $GRAFANA_PATH/data/plugins/
wget https://github.com/CorpGlory/grafana-multibar-graph-panel/releases/download/0.1.2/grafana-multibar-graph-panel-0.1.2.tar.gz
tar -zxvf grafana-multibar-graph-panel-0.1.2.tar.gz

And restart Grafana after that

nsayedqt commented 6 years ago

@rozetko thanks will do now

nsayedqt commented 6 years ago

@rozetko i dont see any change:

infact the date changes when i hover on the bars. See how for 16 Oct, it is showing 15th on one bar, then 16th, then 17th... very confusing.

rozetko commented 6 years ago

Did you restart Grafana server after updating plugin? Seems like Grafana cached an old plugin version Can you please try to clear cache? F12 (Chrome Dev Tools would be opened) -> Right click on refresh button -> Empty Cache and Hard Reload