search

CorpGlory / types-grafana

MIT License
9 stars 22 forks source link

Method missing in MetricsPanelCtrl #3

Closed Jostar1024 closed 6 years ago

Jostar1024 commented 6 years ago

Hi, moveQuery() method of MetricsPanelCtrl is missing in the d.ts file. Would you fix it ?

jonyrock commented 6 years ago

@Jostar1024 thanks a lot, let me check.

jonyrock commented 6 years ago

For protocol:

Definitions: https://github.com/CorpGlory/types-grafana/blob/bc4ec0484d90b9d374e6df567833dc4e292dd0e7/app/features/panel/metrics_panel_ctrl.d.ts

Method in source code: https://github.com/grafana/grafana/blob/cebae404686b6d4390c90a7bb389922a21e97a9a/public/app/features/panel/metrics_panel_ctrl.ts#L345

jonyrock commented 6 years ago

@Jostar1024 I added changes to master

https://github.com/CorpGlory/types-grafana/commit/2ce6e54491a247b9dbfe6b809e43daf2002e8260

Please let me know if it is better now

Jostar1024 commented 6 years ago

Great ! No problem at all for now. Thank you :)