search

CorrelAid / correlaid_website

Source code for the CorrelAid website
https://correlaid.org
3 stars 0 forks source link

Links of top nav should be coloured (only) when a user is on the corresponding page #121

Closed jstet closed 1 year ago

jstet commented 1 year ago

Similar to the bottom nav: when a user is on an about us page, about us is blue.

Code for this: https://github.com/CorrelAid/correlaid_website/blob/main/src/lib/layout/Header.svelte#L175

jstet commented 1 year ago

Links stay green at the moment: 2023-04-26_10-12

jstet commented 1 year ago

I am very sorry about reopening this issue again, but the top nav links still stay green when you click on the correlaid logo

KonradUdoHannes commented 1 year ago

@jstet no worries if its not done its not done. I think its also a good process, because I believe thinking of all edeg cases on the spot is actually a lot harder then reopening an issue when they pop up.

jstet commented 1 year ago

Same issue for the bottom nav btw

KonradUdoHannes commented 1 year ago

I've imlpemented the solution, which is very simple, but I'm not able to currently check whether it fully works because I only have a tablet screen size right now. The fix is in #192.

@jstet if its urgend you can look at the PRs deployment, and if it works merge it. Otherwise I'll check and merge it on Sunday.

jstet commented 1 year ago

Does not work :S 2023-04-29_01-05 Also, when refreshing the page, the color disappears.