CorrelAid / correlaid_website

Source code for the CorrelAid website
https://correlaid.org
3 stars 0 forks source link

Have to scroll in menu on mobile #384

Closed friep closed 11 months ago

friep commented 11 months ago

On my iPhone xs, I have to scroll down to see the donate button and the language switcher. I'm not sure people woulddo this intuitively. I'd be bad if we lost English speaking people who can't find the language switcher.

image

friep commented 11 months ago

I think it's actually visible in the sense that it's on the screen but the safari URL prompt is overlayed?!🥲

LtSalt commented 11 months ago

I guess this might be due to using vh units - they don't respect mobile boundaries. A fix could be using dvh units. Kevin Powell talks about it in this video.

KonradUdoHannes commented 11 months ago

Interesting I wonder whether we can catch this in end to end testing. We should be able to automatically test a viewport corresponding to an iPhone xs and setup safari for the tests. I'm curious to see whether that is enough to simulate the menu at the bottom.

We should also check whether the issue affects our regular footer, which has social media links.

KonradUdoHannes commented 11 months ago

Actually with regard to #410 I'm wondering whether we can solve this in general. If a mobile device is in landscape we there will always be scrolling in the menu, because not even the navigation menu fits on it.

Maybe we need to address the problem from a different angle. For instance, I think scrolling itself might not even the issue, but that its not clear that there is content/widgets further down below that one can scroll to. Maybe we can find a visual solution for this that makes it more apparent to users, that they might want to scroll.

KonradUdoHannes commented 11 months ago

I have no Idea about the implementation effort, but this site has a scrolling indicator that disappears when they are at the bottom. http://cyclemon.com/

jstet commented 11 months ago

@LtSalt wrote me on Slack that he has solved this issue

LtSalt commented 11 months ago

I just created a pull request. It might be worth the while to check if similar issues exist elsewhere on the website.

jstet commented 11 months ago

Looks fine to me, thank you! Lets close this issue then