Closed friep closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
re width: did u add a custom section to the entry in the pages collection?
thanks that fixed it!
re description, how would u deal with the situation of people needing more than one description/a context depended description in this case?
tl;dr: i would not deal with it.
in my opinion the use case is not worth the complexity and added effort of maintaining them in different places. imo there's no harm in using general descriptions that cover all that the person does within CorrelAid. For example, if Marco shows up on LC Konstanz, it's also ok to write that he's part of the board and vice versa. I'd actually argue that it's a plus because it shows that people can be involved in different roles at once.
For blog posts, temporal stability is actually more of a problem (aka: Johannes 8 years ago has the same description as content creator Johannes today) but again, for me, i'd keep it as simple as possible.
If you think this has implications too far for a PR. i can move my comment to the related issue and revert the changes (i guess i am just frustrated that i manually added things in the wrong place in directus)
Okay that makes sense! Fine by me to do it that way
@friep I just have some general comments on dealing with these changes and PRs in general.
npm run init_pre_commit
should do the trick. Now that the changes are already committed npm run format
and npm run lint
can be used to apply the respective tools to the entire codebase not the staged files only. Not sure whether these files are in the readme, but they can all be looked up in the package.json
. If there are any issues here please let me know because we absolutely want to make sure that CI and pre-commit hooks are aligned.npm run build-and-test
with a configuration for static site building as described in the readme. This will catch a lot of errors when either the build or the tests fail. Its not part of the CI but was (and will be again) part of CD.Post {...}
to Post : Blog_Post {...}
will fetch the Blog_Posts
instead of Posts
from graphql, but it will give the Blog_Post
the alias Post
afterwards. This means that any code coming after the fetch won't see a difference.Latest commit: |
616d9ec
|
Status: | ✅ Deploy successful! |
Preview URL: | https://fa342d45.correlaid.pages.dev |
Branch Preview URL: | https://adapt-blog-schema.correlaid.pages.dev |
@jstet i reverted the changes related to the people description. Let's better do this in a controlled manner another time. 👍 i commented in #204 . Then we can also take the time to do refactoring properly.
@KonradUdoHannes thanks for the pointers.
svelte.config.js
. It then fails later on the projects and event routes which makes sense, right? Posts
, i won't die on this hill :)
minor updates after recreating blog schema.
open questions / issues: