CorrelAid / correlaid_website

Source code for the CorrelAid website
https://correlaid.org
3 stars 0 forks source link

Blog schema updates #555

Closed friep closed 8 months ago

friep commented 9 months ago

minor updates after recreating blog schema.

open questions / issues:

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **correlaid** | ⬜️ Ignored ([Inspect](https://vercel.com/correlaid/correlaid/D7FnXn8gzkgzfmocXHqkWRxgpxFv)) | [Visit Preview](https://correlaid-git-adapt-blog-schema-correlaid.vercel.app) | | Aug 9, 2023 1:16pm |
jstet commented 9 months ago

re width: did u add a custom section to the entry in the pages collection?

friep commented 9 months ago

thanks that fixed it!

jstet commented 9 months ago

re description, how would u deal with the situation of people needing more than one description/a context depended description in this case?

friep commented 9 months ago

tl;dr: i would not deal with it.

in my opinion the use case is not worth the complexity and added effort of maintaining them in different places. imo there's no harm in using general descriptions that cover all that the person does within CorrelAid. For example, if Marco shows up on LC Konstanz, it's also ok to write that he's part of the board and vice versa. I'd actually argue that it's a plus because it shows that people can be involved in different roles at once.

For blog posts, temporal stability is actually more of a problem (aka: Johannes 8 years ago has the same description as content creator Johannes today) but again, for me, i'd keep it as simple as possible.

If you think this has implications too far for a PR. i can move my comment to the related issue and revert the changes (i guess i am just frustrated that i manually added things in the wrong place in directus)

jstet commented 9 months ago

Okay that makes sense! Fine by me to do it that way

KonradUdoHannes commented 9 months ago

@friep I just have some general comments on dealing with these changes and PRs in general.

cloudflare-pages[bot] commented 8 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 616d9ec
Status: ✅  Deploy successful!
Preview URL: https://fa342d45.correlaid.pages.dev
Branch Preview URL: https://adapt-blog-schema.correlaid.pages.dev

View logs

friep commented 8 months ago

@jstet i reverted the changes related to the people description. Let's better do this in a controlled manner another time. 👍 i commented in #204 . Then we can also take the time to do refactoring properly.

@KonradUdoHannes thanks for the pointers.

  1. I installed the precommit hooks. linting gives one warning related to image_alt in events.. I don't want to touch this here.
  2. I ran this and did minor changes to svelte.config.js. It then fails later on the projects and event routes which makes sense, right?
  3. interesting and good to know! I still think it's good to have this aligned in the code as well so that we don't diverge terminology wise too much. I've worked in projects where at some point frontend code was using different terminology than backend code and found that quite exhausting to think about. But if it's. important to you to keep the shorter Posts, i won't die on this hill :)