search

CorrelAid / kbtbr

https://correlaid.github.io/kbtbr
Other
7 stars 1 forks source link

Issue29 manage output get #45

Closed dimitri-mar closed 3 years ago

dimitri-mar commented 3 years ago

Get function in the Kobo interface manages two possible output formats: either a parsed JSON response as a list, or a crul::HttpResponse.

MKyhos commented 3 years ago

LGTM! :100: :+1: Thank you so much :)

As this PR has an earlier version of the post-patch-methods branch as an ancestor, I would suggest to proceed with

  1. apply the new styler styling on to any branch to be merged (agreement necessary, see #46 )
  2. merge post-patch-methods into dev (#32 )
  3. merge dev into issue29_manage_output_get, selecting the newer post method versions on conflict
  4. squash merge this branch on dev
pr130 commented 3 years ago

turns out #43 also includes the changes here... 🤯 https://github.com/CorrelAid/kbtbr/pull/43#issuecomment-866302960

pr130 commented 3 years ago

lgtm :)