search

CorrelAidxNL / BankTrack

Collaboration between BankTrack and CorrelAid Netherlands
GNU General Public License v3.0
0 stars 0 forks source link

Added pre-commit #5

Closed LSturtew closed 2 years ago

LSturtew commented 2 years ago

Added pre-commit config yaml and github actions to check the linting.

timlod commented 2 years ago

pre-commit.ci is failing, says a private plan is needed. I haven't worked with this before. @LSturtew what is this for? Doing the same the pre-commit hook does, but on the potentially merged branch? In any case, we should probably remove that if it's not available to us.

LSturtew commented 2 years ago

Pre-commit-ci is basically the same thing I implemented via the gitlab actions. I had looked into using pre-commit-ci for this repo, since it works with github, but because it is only free for open source projects we cannot use it. I have removed it (after I created the MR, that is why it is still here.)

andrewsutjahjo commented 2 years ago

That's weird, I think we agreed with Erik that this would be an open-source project. Let me doublecheck with Fabian and fix it up if correct

timlod commented 2 years ago

This repo is private - if the intention is to be open-source from the first commit we can make the repo public and this would work. But it appears the other one works, so I don't see the benefit of having two of them anyways?