search

CorrieJ98 / HereBeGoblins

HND 2024 Graded Unit - Made in Godot 4.0
GNU General Public License v3.0
1 stars 0 forks source link

Potential Signalling issues #22

Closed CorrieJ98 closed 6 months ago

CorrieJ98 commented 7 months ago

Inside of selection_box.gd (at the beginning of the signal chain) _on_area_selected and _on_selected_unit parameters of Callable do not exist

Not currently a problem as signals are passing and code is running but I have a feeling that this will cause a problem later

CorrieJ98 commented 6 months ago

Fixed:

Reworked GameController to contain UI as its individual components instead of instantiating the UI.tscn scene into GameController

This allowed me to get rid of the hack-job that was the signal chain from SelectionBox through to GameController and instead have a single signal with all the relevant information