search

Corrosive-Games / bevy-parallax

Parallax background plugin for Bevy
MIT License
114 stars 17 forks source link

Updated to bevy 13.0 #37

Closed sardap closed 8 months ago

sardap commented 8 months ago
cdsupina commented 8 months ago

I ran the fishy example and noticed that the backgrounds were all greyscale. It looks your changes broke the functionality added with this PR: #22

Could you try to fix this before we merge this?

Thanks for all of the work you have done so far.

sardap commented 8 months ago

@cdsupina Sorry for missing that I have added the sprite info backinto the SpriteSheetBundle. I noticed the colors look darker than the gif. But I also tested on the bevy 0.11 version and the colours are also darker there.

ettoreleandrotognoli commented 8 months ago

Hello @sardap @cdsupina When I added https://github.com/Corrosive-Games/bevy-parallax/pull/22 the colors were changed I said something like "the final result don't have exactly the same colors"

ettoreleandrotognoli commented 8 months ago

I tested the examples locally The changes LGTM