search

CorruptedArk / did-i-take-my-meds

A Kotlin Android app to manage medications
GNU General Public License v3.0
175 stars 15 forks source link

Misleading "Took it" action on notifications when out of doses #62

Open mjray opened 2 years ago

mjray commented 2 years ago

Describe the bug No warning is given if no doses remain when pressing "Took it" on the notification. The notification closes but no dose is recorded.

To Reproduce Steps to reproduce the behavior:

  1. Make an alert notification appear for a med with no doses remaining
  2. Click on 'Took it'
  3. See notification close
  4. Open app and look at medication: no dose will have been recorded

Expected behavior Display "No doses remaining" instead of "Took it" on the notification and open the med for editing when clicked?

Smartphone (please complete the following information):

ctag commented 1 month ago

Just ran into this. Apparently only occurs for the notification.

Using the "I just took it" button in-app results in expected behavior: image

Using the time-based notification just results in missing dose logs: image