search

CorruptedArk / open-chaos-chess

Open Chaos Chess is a free and open source version of Chaos Chess, stripped of Google Play Services.
GNU General Public License v3.0
50 stars 7 forks source link

Game can be reset while a peice is moving #14

Closed Vuldora closed 4 years ago

Vuldora commented 4 years ago

Usually when you click on the "new game" button the game lets you know "wait until the move has finished".

But if you rapidly click one of your chess peices and click new game at the same time, the game will be reset but the move will still be applied which can result in something likes this:

Screenshot_20201110-171936_Open Chaos Chess

It doesn't affect normal gameplay but I enjoy speedrunning the game and this bug can be an issue sometimes.

CorruptedArk commented 4 years ago

This is an interesting issue, it's going to be a fun one to figure out for sure. My guess is that the move starts executing immediately after the check that the new game button does. That probably allows the game to reset at the same time as the move.

CorruptedArk commented 4 years ago

Also, physically how are you holding your phone and pressing to achieve this? I'm struggling to reproduce the bug myself.

Vuldora commented 4 years ago

Also, physically how are you holding your phone and pressing to achieve this? I'm struggling to reproduce the bug myself.

I am unable to find a way to consistently replicate the bug, the only way I can do it again is by mashing buttons which can cause all sorts of wierd stuff like this: Screenshot_20201110-201552_Open Chaos Chess.jpg

I could link a recording of me performing it but I am not sure which video hosting website should I use (is an unlisted youtube video fine?)

CorruptedArk commented 4 years ago

Wait, you got to the knights only mode without deliberately clicking on the knight in the main menu? And yeah any sort of video hosting should be fine

Vuldora commented 4 years ago

Wait, you got to the knights only mode without deliberately clicking on the knight in the main menu? And yeah any sort of video hosting should be fine

Alright so I think there is 2 seperate bugs going on that arent related

The first I am still unable to replicate.

But the second which is the knight only mode appearing is probably because the knight is hidden under the logo https://youtu.be/wu7QH4DpEys

CorruptedArk commented 4 years ago

Okay, I'm going to probably leave the knight one alone because that is mostly intended behavior, except for maybe blocking the action while underneath other views. Or maybe I'll bring it to the top layer. The first bug is unintended, and I'll have to think about how to fix it

Vuldora commented 4 years ago

Update: I figured out a way to replicate the bug that I mentioned at the start a.k.a "The game can be reset while a piece is moving".

Here is how to do it: 1) Click any of your chess pieces to move it. 2) While that piece is moving, keep tapping on a second piece. 3) The moment your second piece start moving you click "new game"

Outcome: Either the opponent will have a head-start or will get a duplicate piece, which both aren't supposed to happen.

Demonstration: https://youtu.be/IU1fuQ4LEK4

CorruptedArk commented 4 years ago

Alright, thank you for clearly and concisely listing the reproduction steps as well as providing a helpful video. I'll get on it as soon as I can

CorruptedArk commented 4 years ago

This issue should be fixed in v1.6.4 or at least much harder to reproduce than it already is. I personally was unable to reproduce it at all, but maybe my reaction time is too slow. Either way, let me know if you run into the problem again and this issue can be reopened.